Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdGuard to update entry on updated hass.io discovery #24737

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Jun 24, 2019

Description:

When hass.io sends a discovery, check if there is new info, and if so, update the running config entry.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost
Copy link

ghost commented Jun 24, 2019

Hey there @frenck, mind taking a look at this pull request as its been labeled with a integration (adguard) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob balloob added this to the 0.95.0 milestone Jun 24, 2019
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @balloob 👍
Much appreciated

@balloob balloob merged commit 4aedd3a into dev Jun 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the adguard-update-entry branch June 24, 2019 21:46
balloob added a commit that referenced this pull request Jun 24, 2019
@balloob balloob mentioned this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants