Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save cached logi_circle tokens in config folder #24726

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

evanjd
Copy link
Contributor

@evanjd evanjd commented Jun 23, 2019

Breaking change:

The default path for cached Logi Circle tokens has been changed from the working directory to the config folder.

Users who run Home Assistant from a working directory other than their config folder will need to either:

  • Move the .logi_cache.pickle file from their working directory to their config folder, or
  • Add the Logi Circle integration through the integrations menu after updating to recreate the access tokens.

Description:

Resolves an issue where cached tokens for the logi_circle integration were saved in the current working directory, instead of the config folder. This is particularly problematic on Docker-backed HA instances, as the tokens are blown away whenever the container is recreated.

Related issue (if applicable): fixes #24533

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

logi_circle:
  client_id: YOUR_CLIENT_ID
  client_secret: YOUR_CLIENT_SECRET
  api_key: YOUR_API_KEY
  redirect_uri: YOUR_REDIRECT_URI

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Instead of the working directory, which it's doing currently. Matches pattern observed on Abode, Ring, Skybell integrations.
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks.

@balloob balloob merged commit ee18844 into home-assistant:dev Jun 24, 2019
@balloob balloob added this to the 0.95.0 milestone Jun 24, 2019
balloob pushed a commit that referenced this pull request Jun 24, 2019
Instead of the working directory, which it's doing currently. Matches pattern observed on Abode, Ring, Skybell integrations.
@evanjd evanjd deleted the logi-circle-bugfix-#24533 branch June 24, 2019 22:57
@balloob balloob mentioned this pull request Jun 26, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
Instead of the working directory, which it's doing currently. Matches pattern observed on Abode, Ring, Skybell integrations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logi Circle: .logi_cache.pickle is saved in working directory, not config
3 participants