Add show_as_state options to Life360 #24725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: life360
small-pr
ghost
assigned 
|
This pull request has been mentioned on Home Assistant Community. There might be relevant details there: |
|
This pull request has been mentioned on Home Assistant Community. There might be relevant details there: https://community.home-assistant.io/t/life360-device-tracker-platform/52406/1139 |
2 tasks
balloob
reviewed
Jun 24, 2019
| # If user wants driving or moving to be shown as state, and current | ||
| # location is not in a HA zone, then set location name accordingly. | ||
| loc_name = None | ||
| active_zone = run_callback_threadsafe( |
There was a problem hiding this comment.
For a future PR, this should all become async.
balloob
approved these changes
Jun 24, 2019
|
Thanks! |
balloob
pushed a commit
that referenced
this pull request
Jun 24, 2019
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The original Life360 custom integration had a feature whereby the entity's state could be set to driving or moving if the device was not in a HA zone and the Life360 server indicated the device was driving or moving, respectively. This feature was removed when submitted to become a standard integration.
Users have requested this feature be added to the standard integration.
Related issue (if applicable): N/A
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9684
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: