Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend websocket method usage to port 8002 in Samsung TV media player #24716

Merged
merged 1 commit into from
Jun 23, 2019

Conversation

2sheds
Copy link
Contributor

@2sheds 2sheds commented Jun 23, 2019

Description:

Related issue (if applicable): fixes #17802

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Contributor

Hi @2sheds,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@2sheds 2sheds changed the title Extend websocket method usage to port 8002 in Samsung TV media player #17802 Extend websocket method usage to port 8002 in Samsung TV media player Jun 23, 2019
@balloob balloob added this to the 0.95.0 milestone Jun 23, 2019
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balloob balloob merged commit dc6a44d into home-assistant:dev Jun 23, 2019
@2sheds
Copy link
Contributor Author

2sheds commented Jun 23, 2019

Thanks for accepting this but I purposely left out the "fixed" part - I don't believe this alone fixes the issue, it still requires the patched samsungctl library for SSL websockets support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.81.0] Samsung TV not working
3 participants