Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added percent to the disk,memory and swap percent labels #24575

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Added percent to the disk,memory and swap percent labels #24575

merged 1 commit into from
Jun 17, 2019

Conversation

cliffordwhansen
Copy link
Contributor

Breaking Change:

The disk_use, memory_use and swap_use percentage items will now have percentage in the name.

Description:

Currently the disk_use, memory_use and swap_use entities are duplicated in random order

Related issue (if applicable): fixes #24574

Example entry for configuration.yaml (if applicable):

  - platform: glances
    host: 10.18.1.1
    name: Medusa
    version: 2
    resources:
      - disk_use_percent
      - disk_use
      - memory_use_percent
      - memory_use
      - swap_use_percent
      - swap_use

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@cliffordwhansen cliffordwhansen requested a review from fabaff as a code owner June 17, 2019 12:48
@ghost ghost assigned fabaff Jun 17, 2019
@ghost
Copy link

ghost commented Jun 17, 2019

Hey there @fabaff, mind taking a look at this pull request as its been labeled with a integration (glances) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob balloob merged commit 0a13c47 into home-assistant:dev Jun 17, 2019
@balloob balloob mentioned this pull request Jun 26, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glances disk, mem and swap usage entities random order
4 participants