Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load last_checkpoint if shipment is pending #24301

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

davidbb
Copy link
Contributor

@davidbb davidbb commented Jun 4, 2019

Description:

If a shipment is pending, it won't have a dictionary that includes its last_checkpoint. Prior to this change, the component would crash on startup if any packages were in pending state.

Related issue (if applicable): fixes #23554

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@davidbb davidbb marked this pull request as ready for review June 5, 2019 00:51
@andrewsayre andrewsayre merged commit 3b8f254 into home-assistant:dev Jun 6, 2019
@balloob balloob mentioned this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aftership sensor error
4 participants