Vlc telnet #24290
Merged
Vlc telnet #24290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First functional version, remains to add more functionality.
Module renamed Fixed module rename in other
2 tasks
OttoWinter
reviewed
Jun 4, 2019
| self._host = host | ||
| self._port = port | ||
| self._password = passwd | ||
| self._vlc = None |
There was a problem hiding this comment.
Though it's probably not too easy to achieve, this could have a timing issue: What if one of the functions like play_media is called before update? Please add , True to add_entities call to update on start.
There was a problem hiding this comment.
Added the parameter! There is another case... what if the state is unavailable because the connection to VLC can't be made, but the user calls to play_media. The current behavior will be an exception thrown "None has no attribute...". Should I throw another exception or return False?
Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com>
Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com>
Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com>
Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com>
+Manage error when the VLC dissapears to show status unavailable.
pvizeli
reviewed
Jun 5, 2019
-Import location -Use of constants
pvizeli
approved these changes
Jun 21, 2019
balloob
pushed a commit
that referenced
this pull request
Jun 21, 2019
* Vlc telnet first commit First functional version, remains to add more functionality. * New functions added and bugfixes * Compliance with dev checklist * Compliance with dev checklist * Compliance with pydocstyle * Removed unused import * Fixed wrong reference for exception * Module renamed * Fixed module rename in other * Fixed wrong reference for exception Module renamed Fixed module rename in other * Update homeassistant/components/vlc_telnet/media_player.py Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com> * Update homeassistant/components/vlc_telnet/media_player.py Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com> * Update homeassistant/components/vlc_telnet/media_player.py Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com> * Update homeassistant/components/vlc_telnet/media_player.py Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com> * Suggestions by @OttoWinter +Manage error when the VLC dissapears to show status unavailable. * Removed error log, instead set unavailable state * Changes suggested by @pvizeli -Import location -Use of constants * Implemented available method * Improved available method
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Oct 12, 2019
* Vlc telnet first commit First functional version, remains to add more functionality. * New functions added and bugfixes * Compliance with dev checklist * Compliance with dev checklist * Compliance with pydocstyle * Removed unused import * Fixed wrong reference for exception * Module renamed * Fixed module rename in other * Fixed wrong reference for exception Module renamed Fixed module rename in other * Update homeassistant/components/vlc_telnet/media_player.py Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com> * Update homeassistant/components/vlc_telnet/media_player.py Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com> * Update homeassistant/components/vlc_telnet/media_player.py Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com> * Update homeassistant/components/vlc_telnet/media_player.py Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com> * Suggestions by @OttoWinter +Manage error when the VLC dissapears to show status unavailable. * Removed error log, instead set unavailable state * Changes suggested by @pvizeli -Import location -Use of constants * Implemented available method * Improved available method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Trying to resolve this issue referenced in the vlc component doc I developed a component to control any instance of VLC running its built in telnet interface.
Alongside with this component, I've put together an add-on for the hassio platform to run a VLC instance locally.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9558
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: