-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Battery attribute & accuracy filter #24277
Conversation
…accuracy filter option
Hey there @ludeeus, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
Co-Authored-By: Otto Winter <otto@otto-winter.com>
Co-Authored-By: Otto Winter <otto@otto-winter.com>
Use [] syntax for keys that are in the validated data. Co-Authored-By: Otto Winter <otto@otto-winter.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, waiting for comment from @ludeeus as code owner.
Breaking Change:
battery_level
attribute changes tobattery
.Since a
device_tracker
component contains a standart attribute forbattery
level, that we can use with see service, update with async_see method, we should use it for maintain component criteria and not create a new attribute for the same pourpose with a different name.To solve this breaking change, only need to replace the
battery_level
attribute withbattery
in all templates than use the battery attribute of any traccar device_tracker.Description:
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9347
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirements
in the manifest (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.Note: From #2329 [Outdated]