Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in integration component #24250

Merged
merged 1 commit into from
Jun 2, 2019
Merged

Fix typo in integration component #24250

merged 1 commit into from
Jun 2, 2019

Conversation

Emilv2
Copy link
Contributor

@Emilv2 Emilv2 commented Jun 2, 2019

Description:

Fix a typo in ICON, char-histogram does not exists, I assume it should have been chart-histogram.

Related issue (if applicable): Same as #24217, but a new pull request because Github shows wrong commits.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@Emilv2 Emilv2 requested a review from dgomes as a code owner June 2, 2019 07:17
@ghost ghost assigned dgomes Jun 2, 2019
@ghost
Copy link

ghost commented Jun 2, 2019

Hey there @dgomes, mind taking a look at this pull request as its been labeled with a integration (integration) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@robbiet480 robbiet480 merged commit c486f79 into home-assistant:dev Jun 2, 2019
@Emilv2 Emilv2 deleted the integration_icon branch June 2, 2019 08:23
@balloob balloob mentioned this pull request Jun 26, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants