Fix ESPHome config flow with invalid config entry #24213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: esphome
small-pr
ghost
assigned 
|
You can cherry-pick it self to rc |
|
@pvizeli Ok, will do that after the PR is merged, thanks! |
OttoWinter
added a commit
that referenced
this pull request
May 31, 2019
|
Ok, successfully cherry picked it into rc - I removed the PR from the milestone because it's already cherry-picked. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Reported by @VDRainer in #beta discord chat.
This happens when there's a config entry that never connected to the node - I'm not sure how such a state is possible unless some .storage files were messed with or the node was disconnected right after the config flow was ready.
Anyway, this patch stops other config flows from crashing in that case.
Depending on the cherry pick strategy option this can result in a failed cherry pick - best choose
theirsas strategy option.Checklist:
tox. Your PR cannot be merged unless tests pass