Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer allow invalid slugs or extra keys #24176

Merged
merged 5 commits into from
May 30, 2019
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented May 29, 2019

Breaking Change:

As announced prior, invalid slugs and extra keys are now no longer automatically fixed but instead will become config validation failures.

Description:

Remove support for invalid slugs and extra config keys.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner May 29, 2019 17:34
@homeassistant homeassistant added cla-signed core small-pr PRs with less than 30 lines. labels May 29, 2019
@@ -737,7 +704,7 @@ def extend(self, schema, required=None, extra=None):
return HASchema(ret.schema, required=required, extra=self.extra)


PLATFORM_SCHEMA = HASchema({
PLATFORM_SCHEMA = vol.Schema({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also remove the extra keys warning - is that also supposed to be part of this PR? Shouldn't we also remove the class too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra keys was supposed to be removed after 0.92, so think this would be a fitting moment? I didn't remove the class but you're right, I should .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can remove it no problem.

Was just wondering because it was not part of the description/breaking change section and it looked like this slipped in.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good point, addressed it.

@balloob balloob changed the title No longer allow invalid slugs No longer allow invalid slugs or extra keys May 29, 2019
@balloob balloob force-pushed the no-longer-allow-slugs branch from 9621935 to f33c842 Compare May 29, 2019 21:31
@pvizeli pvizeli merged commit 59ce31f into dev May 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the no-longer-allow-slugs branch May 30, 2019 11:33
@balloob balloob mentioned this pull request Jun 26, 2019
@ktpx
Copy link

ktpx commented Jun 27, 2019

"As announced prior, invalid slugs and extra keys are now no longer automatically fixed but instead will become config validation failures."

What does that really mean?

@home-assistant home-assistant locked as spam and limited conversation to collaborators Jun 27, 2019
@pvizeli
Copy link
Member

pvizeli commented Jun 27, 2019

Please open an issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants