-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer allow invalid slugs or extra keys #24176
Conversation
@@ -737,7 +704,7 @@ def extend(self, schema, required=None, extra=None): | |||
return HASchema(ret.schema, required=required, extra=self.extra) | |||
|
|||
|
|||
PLATFORM_SCHEMA = HASchema({ | |||
PLATFORM_SCHEMA = vol.Schema({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will also remove the extra keys warning - is that also supposed to be part of this PR? Shouldn't we also remove the class too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extra keys was supposed to be removed after 0.92, so think this would be a fitting moment? I didn't remove the class but you're right, I should .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can remove it no problem.
Was just wondering because it was not part of the description/breaking change section and it looked like this slipped in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good point, addressed it.
9621935
to
f33c842
Compare
"As announced prior, invalid slugs and extra keys are now no longer automatically fixed but instead will become config validation failures." What does that really mean? |
Please open an issue |
Breaking Change:
As announced prior, invalid slugs and extra keys are now no longer automatically fixed but instead will become config validation failures.
Description:
Remove support for invalid slugs and extra config keys.
Checklist:
tox
. Your PR cannot be merged unless tests passIf the code does not interact with devices: