-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Round Awair sensor values #24093
Round Awair sensor values #24093
Conversation
Can you please rebase? The PR contains some changes in CODEOWNERS which seems unrelated. |
@fabaff I got errors in the tests due to the code owners. I added my git name and ran the tool to fix it but indeed after running the tool some things seemed weird. Will rebase now and run the tool again. |
Codecov Report
@@ Coverage Diff @@
## dev #24093 +/- ##
==========================================
- Coverage 94.21% 94.13% -0.09%
==========================================
Files 506 501 -5
Lines 39639 39405 -234
==========================================
- Hits 37347 37094 -253
- Misses 2292 2311 +19
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## dev #24093 +/- ##
==========================================
- Coverage 94.21% 94.13% -0.09%
==========================================
Files 506 501 -5
Lines 39639 39405 -234
==========================================
- Hits 37347 37094 -253
- Misses 2292 2311 +19
Continue to review full report at Codecov.
|
@fabaff, thanks for the review. It should be better now. |
Description:
Currently the sensor reports about 10 figures after the comma which isn't useful in the overview (numbers end in ...). This PR rounds it to one figure after the comma instead which is around the sensor precision anyway.
Should fix #20034
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: