Expose door cover/binary_sensor as door type #23307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More logical to ask "What doors are open" than "What sensors are open"
homeassistant
added
core
integration: google_assistant
small-pr
balloob
approved these changes
Apr 22, 2019
|
Can you update our parameterized tests to make sure it works? |
|
Tagging for 92 so people won't have device type changing on them. |
balloob
reviewed
Apr 23, 2019
| @@ -598,6 +600,89 @@ def registries(hass): | |||
| } | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("device_class,google_type", [ | |||
| ('door', 'action.devices.types.DOOR'), | |||
| ('garage_door', 'action.devices.types.SENSOR'), | |||
There was a problem hiding this comment.
This seems incorrect, as we have this map to TYPE_GARAGE ?
There was a problem hiding this comment.
Not currently for the binary sensor only for cover.
10 tasks
balloob
pushed a commit
that referenced
this pull request
Apr 24, 2019
* Expose door cover/binary_sensor as door type More logical to ask "What doors are open" than "What sensors are open" * Add test for binary_sensor device_classes * Cosmetic flake8 * Add test for device class for cover
fredrikbaberg
pushed a commit
to fredrikbaberg/home-assistant
that referenced
this pull request
May 6, 2019
* Expose door cover/binary_sensor as door type More logical to ask "What doors are open" than "What sensors are open" * Add test for binary_sensor device_classes * Cosmetic flake8 * Add test for device class for cover
fredrikbaberg
pushed a commit
to fredrikbaberg/home-assistant
that referenced
this pull request
May 6, 2019
* Expose door cover/binary_sensor as door type More logical to ask "What doors are open" than "What sensors are open" * Add test for binary_sensor device_classes * Cosmetic flake8 * Add test for device class for cover
fredrikbaberg
pushed a commit
to fredrikbaberg/home-assistant
that referenced
this pull request
May 6, 2019
* Expose door cover/binary_sensor as door type More logical to ask "What doors are open" than "What sensors are open" * Add test for binary_sensor device_classes * Cosmetic flake8 * Add test for device class for cover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
More logical to ask "What doors are open" than "What sensors are open".
Since sensors type is a unsupported type, we might as well use the correct unsupported type
of doors.
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
Documentation added/updated in home-assistant.ioIf the code communicates with devices, web services, or third-party tools:
The manifest file has all fields filled out correctly (example).New dependencies have been added torequirementsin the manifest (example).New dependencies are only imported inside functions that use them (example).New or updated dependencies have been added torequirements_all.txtby runningscript/gen_requirements_all.py.New files were added to.coveragerc.If the code does not interact with devices: