Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hue motion sensors are motion sensors, not presence sensors. #23193

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

mitchellrj
Copy link
Contributor

Fixes #23186

@github-actions
Copy link

Hey there @balloob, mind taking a look at this pull request as its been labeled with a integration (hue) you are listed as a codeowner for? Thanks!

@balloob balloob added this to the 0.92.0 milestone Apr 18, 2019
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #23193 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #23193   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files         457      457           
  Lines       37085    37085           
=======================================
  Hits        34938    34938           
  Misses       2147     2147
Impacted Files Coverage Δ
homeassistant/components/hue/binary_sensor.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11fb486...817a2cd. Read the comment docs.

@balloob balloob merged commit f57191e into home-assistant:dev Apr 18, 2019
@jimbob1001
Copy link

Does this also mean that the name of the entities will change so that they end with "_motion" instead of "_presence" ?

@mitchellrj
Copy link
Contributor Author

mitchellrj commented Apr 18, 2019 via email

fredrikbaberg pushed a commit to fredrikbaberg/home-assistant that referenced this pull request May 6, 2019
fredrikbaberg pushed a commit to fredrikbaberg/home-assistant that referenced this pull request May 6, 2019
fredrikbaberg pushed a commit to fredrikbaberg/home-assistant that referenced this pull request May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hue native sensors: motion reports as presence
5 participants