Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lightwave config validation #22576

Merged
merged 1 commit into from
Mar 31, 2019

Conversation

amelchio
Copy link
Contributor

Breaking Change:

Lightwave configuration was not properly validated before, it is now. This can cause invalid configurations to finally be flagged as such.

Description:

A missing vol.All meant that the schema would validate anything as long as cv.has_at_least_one_key passed.

I do not use this component so I only tested startup.

Example entry for configuration.yaml (if applicable):

lightwave:
    lights:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

@andrewsayre
Copy link
Member

Note to self... don't use GitHawk to try and add a label. It nukes them all...

@andrewsayre andrewsayre merged commit 1b0b5b4 into home-assistant:dev Mar 31, 2019
unibeck pushed a commit to unibeck/home-assistant that referenced this pull request Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants