-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added check for ebusd monitored conditions validity #22461
Conversation
Hi @danielkucera, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Hi @danielkucera, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Hi @danielkucera, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Hi @danielkucera, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Hi @fabaff , I'm little bit lost in here. Can you please explain what needs to be done for this to be merged? |
Finally all test are passed. Can someone please review and merge? |
Ping. @rohankapoorcom |
ebusd: added check for monitored conditions validity within correct circuit
Description:
This changes condition check to use list from correct circuit. Before this was statically defined for one circuit and throw error for conditions from other circuits
Related issue (if applicable): fixes #21370
Checklist:
tox
. Your PR cannot be merged unless tests pass