Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for ebusd monitored conditions validity #22461

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Added check for ebusd monitored conditions validity #22461

merged 1 commit into from
Jun 6, 2019

Conversation

danielkucera
Copy link
Contributor

@danielkucera danielkucera commented Mar 27, 2019

ebusd: added check for monitored conditions validity within correct circuit

Description:

This changes condition check to use list from correct circuit. Before this was statically defined for one circuit and throw error for conditions from other circuits

Related issue (if applicable): fixes #21370

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@homeassistant
Copy link
Contributor

Hi @danielkucera,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant/components/ebusd/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/ebusd/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/ebusd/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/ebusd/__init__.py Outdated Show resolved Hide resolved
@ghost ghost added the in progress label Mar 27, 2019
@homeassistant
Copy link
Contributor

Hi @danielkucera,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant/components/ebusd/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/ebusd/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/ebusd/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/ebusd/__init__.py Outdated Show resolved Hide resolved
@homeassistant
Copy link
Contributor

Hi @danielkucera,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@homeassistant
Copy link
Contributor

Hi @danielkucera,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@fabaff fabaff changed the title ebusd: added check for monitored conditions validity Added check for ebusd monitored conditions validity Mar 27, 2019
@danielkucera
Copy link
Contributor Author

Hi @fabaff , I'm little bit lost in here. Can you please explain what needs to be done for this to be merged?

@danielkucera
Copy link
Contributor Author

Finally all test are passed. Can someone please review and merge?

@danielkucera
Copy link
Contributor Author

Ping. @rohankapoorcom

@balloob balloob merged commit 32844bb into home-assistant:dev Jun 6, 2019
@balloob balloob mentioned this pull request Jun 26, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ebusd init error
4 participants