Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pyHS100 to 0.3.3 #16502

Merged
merged 1 commit into from
Sep 8, 2018
Merged

Update pyHS100 to 0.3.3 #16502

merged 1 commit into from
Sep 8, 2018

Conversation

amelchio
Copy link
Contributor

@amelchio amelchio commented Sep 8, 2018

Description:

Fixes #15582 and a UTF-8 decoding bug that does not have a HA issue.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@amelchio amelchio requested a review from rytilahti as a code owner September 8, 2018 21:21
@ghost ghost assigned amelchio Sep 8, 2018
@ghost ghost added the in progress label Sep 8, 2018
@rytilahti
Copy link
Member

rytilahti commented Sep 8, 2018 •
edited
Loading

LGTM. This will also fix #15582 (thanks to @tempse).

@amelchio amelchio merged commit 7d590a6 into home-assistant:dev Sep 8, 2018
@ghost ghost removed the in progress label Sep 8, 2018
@balloob balloob mentioned this pull request Sep 17, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rytilahti rytilahti Awaiting requested review from rytilahti

Assignees

@amelchio amelchio

Labels
cla-signed integration: tplink small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amelchio @rytilahti @homeassistant