Weather Platform - IPMA #14716
Merged
Weather Platform - IPMA #14716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| """ | ||
| import logging | ||
| from datetime import timedelta | ||
| import async_timeout |
There was a problem hiding this comment.
Group 3rd party imports and have a blank line between the three groups standard library, 3rd party and homeassistant imports.
|
|
||
| def __init__(self, station, config): | ||
| """Initialise the platform with a data instance and station name.""" | ||
| self._stationname = config.get(CONF_NAME, station.local) |
| @property | ||
| def condition(self): | ||
| """Return the current condition.""" | ||
| return [k for k, v in CONDITION_CLASSES.items() |
There was a problem hiding this comment.
return next((
k for k, v in CONDITION_CLASSES.items()
if self._forecast[0].idWeatherType in v), None)| @property | ||
| def visibility(self): | ||
| """Return the current visibility.""" | ||
| return None |
There was a problem hiding this comment.
Don't overwrite if not used.
| data_out = {} | ||
| data_out[ATTR_FORECAST_TIME] = data_in.forecastDate | ||
| data_out[ATTR_FORECAST_CONDITION] =\ | ||
| [k for k, v in CONDITION_CLASSES.items() |
There was a problem hiding this comment.
Use next and generator expression.
| return fcdata_out | ||
|
|
||
| @property | ||
| def state_attributes(self): |
There was a problem hiding this comment.
Don't overwrite state_attributes. Use device_state_attributes. It will be merged with state_attributes during a state update.
|
Thanks for the review! 👍 |
MartinHjelmare
approved these changes
Jun 3, 2018
|
Coveralls been acting up lately. Merging since we've got 97% coverage in this module. |
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* initial commit * lint * update with pyipma * Added test * Added test * lint * missing dep * address comments * lint * make sure list is iterable * don't bother with list * mock dependency * no need to add test requirements * last correction
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This new platform provides weather information made publicly available by the Portuguese Weather service (Instituto Português do Mar e Atmosfera - IPMA)
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5465
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: