Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct version pinned #13528

Merged
merged 2 commits into from
Mar 30, 2018

Conversation

syssi
Copy link
Member

@syssi syssi commented Mar 29, 2018

This is part of #13511. The construct version must be pinned because of an unstable API. The relaxed requirement of the eddystone_temperature sensor (beacontools) overrules the strict requirement of python-miio. All components are construct==2.9.41 compatible.

@syssi syssi added this to the 0.66 milestone Mar 29, 2018
@MartinHjelmare
Copy link
Member

It's good to link to a source describing the API changes and background to instability. Perhaps here:
http://construct.readthedocs.io/en/latest/transition29.html

@pvizeli
Copy link
Member

pvizeli commented Mar 29, 2018

I don't think that is needed. You have pinned this on your library and beacontools use: 'construct>=2.8.16,<2.10. In this case it should be correct done with docker. @balloob do we now also pin library they we are not based directly?

@syssi
Copy link
Member Author

syssi commented Mar 29, 2018

@pvizeli The latest docker images are build with construct 2.9.40 although python-miio 0.3.8 requires/pinned 2.9.31. This PR tries to avoid the problem as long it's not solved. If you rebuild the docker image (without pinning construct) the most recent version will be picked.

@balloob
Copy link
Member

balloob commented Mar 30, 2018

I'm fine with the pinning while we figure out why the Docker builds don't respect the range as defined by python-miio

@balloob balloob merged commit ab9b915 into home-assistant:dev Mar 30, 2018
balloob pushed a commit that referenced this pull request Mar 30, 2018
* Construct added to the requirements

* requirements_all.txt updated
@balloob balloob mentioned this pull request Mar 30, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants