Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fan setpoints for flexit_bacnet #133388

Merged

Conversation

lellky
Copy link
Contributor

@lellky lellky commented Dec 16, 2024

Breaking change

Proposed change

Fixes a bug that made the integration break when setting fan setpoints.

The Flexit App works like this: if the Home extract/supply setpoint is 74, then the Away extract/supply setpoint must be 74 or lower i.e., max values for the Away extract/supply setpoints is the setpoints for Home extract/supply.

High setpoints can't be set lower than Home setpoints.

Also for setpoints not depending on other setpoints, the lowest value seems to be 30 (not 0, see screenshots and table below).

Mode Setpoint Min Max
HOME Supply AWAY Supply setpoint 100
HOME Extract AWAY Extract setpoint 100
AWAY Supply 30 HOME Supply setpoint
AWAY Extract 30 HOME Extract setpoint
HIGH Supply HOME Supply setpoint 100
HIGH Extract HOME Extract setpoint 100
COOKER_HOOD Supply 30 100
COOKER_HOOD Extract 30 100
FIREPLACE Supply 30 100
FIREPLACE Extract 30 100

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Screenshot_20241216-215155

Screenshot_20241216-215205

Screenshot_20241216-215217

@home-assistant
Copy link

Hey there @piotrbulinski, mind taking a look at this pull request as it has been labeled with an integration (flexit_bacnet) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of flexit_bacnet can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign flexit_bacnet Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@lellky lellky marked this pull request as ready for review December 16, 2024 21:50
@epenet epenet changed the title Fixes fan setpoints for flexit_bacnet (#133378) Fixes fan setpoints for flexit_bacnet Dec 17, 2024
@lellky lellky force-pushed the flexit_bacnet/fixes_fan_setpoints branch from 10150bc to eb56263 Compare December 17, 2024 08:51
@epenet epenet changed the title Fixes fan setpoints for flexit_bacnet Fix fan setpoints for flexit_bacnet Dec 17, 2024
@lellky lellky force-pushed the flexit_bacnet/fixes_fan_setpoints branch from eb56263 to 6d9b920 Compare December 17, 2024 09:10
@joostlek joostlek added this to the 2024.12.4 milestone Dec 17, 2024
@joostlek joostlek merged commit ce0117b into home-assistant:dev Dec 17, 2024
34 checks passed
@lellky
Copy link
Contributor Author

lellky commented Dec 17, 2024

Thanks @joostlek !

frenck pushed a commit that referenced this pull request Dec 17, 2024
@frenck frenck mentioned this pull request Dec 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flexit integration breaks when setting Away extract/supply setpoint
4 participants