-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fan setpoints for flexit_bacnet #133388
Merged
joostlek
merged 1 commit into
home-assistant:dev
from
lellky:flexit_bacnet/fixes_fan_setpoints
Dec 17, 2024
Merged
Fix fan setpoints for flexit_bacnet #133388
joostlek
merged 1 commit into
home-assistant:dev
from
lellky:flexit_bacnet/fixes_fan_setpoints
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @piotrbulinski, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
epenet
changed the title
Fixes fan setpoints for flexit_bacnet (#133378)
Fixes fan setpoints for flexit_bacnet
Dec 17, 2024
lellky
force-pushed
the
flexit_bacnet/fixes_fan_setpoints
branch
from
December 17, 2024 08:51
10150bc
to
eb56263
Compare
epenet
reviewed
Dec 17, 2024
epenet
changed the title
Fixes fan setpoints for flexit_bacnet
Fix fan setpoints for flexit_bacnet
Dec 17, 2024
lellky
force-pushed
the
flexit_bacnet/fixes_fan_setpoints
branch
from
December 17, 2024 09:10
eb56263
to
6d9b920
Compare
joostlek
approved these changes
Dec 17, 2024
Thanks @joostlek ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Fixes a bug that made the integration break when setting fan setpoints.
The Flexit App works like this: if the Home extract/supply setpoint is 74, then the Away extract/supply setpoint must be 74 or lower i.e., max values for the Away extract/supply setpoints is the setpoints for Home extract/supply.
High setpoints can't be set lower than Home setpoints.
Also for setpoints not depending on other setpoints, the lowest value seems to be 30 (not 0, see screenshots and table below).
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: