Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nice-go to 1.0.0 #133185

Merged
merged 3 commits into from
Dec 14, 2024
Merged

Bump nice-go to 1.0.0 #133185

merged 3 commits into from
Dec 14, 2024

Conversation

IceBotYT
Copy link
Contributor

Proposed change

Bumps nice-go to 1.0.0.
Despite the "major update", it isn't major at all, I'm just following semver due to the removal of the desired property from the API.
Changelog: https://github.com/IceBotYT/nice-go/releases/tag/1.0.0
Diff: IceBotYT/nice-go@0.3.10...1.0.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@IceBotYT
Copy link
Contributor Author

If this is able to be in the next patch release, that would be great 👍

@IceBotYT IceBotYT marked this pull request as ready for review December 14, 2024 05:22
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fact about semver. Below 1.0.0 you are allowed to just do breaking changes

@joostlek joostlek merged commit bce6127 into home-assistant:dev Dec 14, 2024
65 checks passed
@IceBotYT
Copy link
Contributor Author

Fun fact about semver. Below 1.0.0 you are allowed to just do breaking changes

I wanted to bring it out of 0.x.x anyway 🤷‍♂️

@IceBotYT IceBotYT deleted the nice-go-1.0.0 branch December 14, 2024 14:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2024
@joostlek joostlek added this to the 2024.12.5 milestone Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants