Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix to use evohome's new hostname #133085

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

zxdavb
Copy link
Contributor

@zxdavb zxdavb commented Dec 12, 2024

Please cherry-pick this PR for the next drop, thanks.

Proposed change

Bump client library to 0.4.21:

The only difference is to change the hostname from tccna.honeywell.com to tccna.resideo.com. This is neccessary becaus ethe server's SSL cert no longer supports the old hostname.

(in future, we'll have to change the branding for evohome)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek joostlek added this to the 2024.12.3 milestone Dec 12, 2024
@zxdavb zxdavb changed the title Switch to using evohome's new hostname Bugfix to use evohome's new hostname Dec 12, 2024
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@frenck frenck merged commit de89be0 into home-assistant:dev Dec 13, 2024
65 checks passed
frenck pushed a commit that referenced this pull request Dec 13, 2024
@frenck frenck mentioned this pull request Dec 13, 2024
@alexbakrasp
Copy link

Super👍

@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants