Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LaMetric config flow for cloud import path #133039

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix LaMetric config flow for cloud import path #133039

merged 1 commit into from
Dec 12, 2024

Conversation

frenck
Copy link
Member

@frenck frenck commented Dec 12, 2024

Proposed change

I received a newer (additional) LaMetric model, meaning I got to test the flow with having multiple LaMetric devices IRL, which uncovered two issues with this flow.

  1. The translations didn't show (wrong step name in translations)
  2. The discovered device (happening in the background) causes an already in-progress to be raised.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @robbiet480, @bachya, mind taking a look at this pull request as it has been labeled with an integration (lametric) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lametric can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign lametric Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frenck 👍

@edenhaus edenhaus merged commit 5c80ddb into dev Dec 12, 2024
34 checks passed
@edenhaus edenhaus deleted the frenck-2024-0621 branch December 12, 2024 12:49
@edenhaus edenhaus added this to the 2024.12.3 milestone Dec 12, 2024
@frenck frenck mentioned this pull request Dec 13, 2024
await self.async_set_unique_id(device.serial_number)
await self.async_set_unique_id(
device.serial_number,
raise_on_progress=False,
Copy link
Member

@MartinHjelmare MartinHjelmare Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing a test for the case where there's another flow in progress.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add one 👍

@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants