Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exception handling for python3.13 for getpass.getuser() #132449

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Dec 6, 2024

Proposed change

Update exception handling for python3.13 for getpass.getuser(). As part of the CHANGELOG:

An OSError is now raised by getpass.getuser() for any failure to retrieve a username, instead of ImportError on non-Unix platforms or KeyError on Unix platforms where the password database is empty.

This updates the logic added in #59667 to handle both the python3.13 exceptions in addition to previously thrown exceptions from earlier versions. In python 3.13 and beyond, the only exception thrown is OSError.

This is currently observed as an issue on some unsupported container use cases, but also appears like it can happen in other scenarios also.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@allenporter allenporter requested a review from a team as a code owner December 6, 2024 03:27
@home-assistant home-assistant bot added cla-signed core small-pr PRs with less than 30 lines. labels Dec 6, 2024
@bdraco bdraco added this to the 2024.12.1 milestone Dec 6, 2024
@bdraco bdraco added the bugfix label Dec 6, 2024
@bdraco
Copy link
Member

bdraco commented Dec 6, 2024

Seems like this is fix for a regression as a result of the update to Python 3.13 so I tagged it

frenck and others added 2 commits December 6, 2024 10:01
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@allenporter
Copy link
Contributor Author

Comment fixes look good, thank you.

@allenporter allenporter merged commit 35438f6 into home-assistant:dev Dec 6, 2024
64 checks passed
frenck added a commit that referenced this pull request Dec 6, 2024
* Update exception handling for python3.13 for getpass.getuser()

* Add comment

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

* Cleanup trailing space

---------

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@frenck frenck mentioned this pull request Dec 6, 2024
vche pushed a commit to vche/hass-core that referenced this pull request Dec 7, 2024
…assistant#132449)

* Update exception handling for python3.13 for getpass.getuser()

* Add comment

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

* Cleanup trailing space

---------

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants