-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update exception handling for python3.13 for getpass.getuser() #132449
Merged
allenporter
merged 3 commits into
home-assistant:dev
from
allenporter:system-info-python3.13
Dec 6, 2024
Merged
Update exception handling for python3.13 for getpass.getuser() #132449
allenporter
merged 3 commits into
home-assistant:dev
from
allenporter:system-info-python3.13
Dec 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
approved these changes
Dec 6, 2024
Seems like this is fix for a regression as a result of the update to Python 3.13 so I tagged it |
epenet
reviewed
Dec 6, 2024
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
frenck
approved these changes
Dec 6, 2024
Comment fixes look good, thank you. |
frenck
added a commit
that referenced
this pull request
Dec 6, 2024
* Update exception handling for python3.13 for getpass.getuser() * Add comment Co-authored-by: epenet <6771947+epenet@users.noreply.github.com> * Cleanup trailing space --------- Co-authored-by: Franck Nijhof <frenck@frenck.nl> Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Merged
vche
pushed a commit
to vche/hass-core
that referenced
this pull request
Dec 7, 2024
…assistant#132449) * Update exception handling for python3.13 for getpass.getuser() * Add comment Co-authored-by: epenet <6771947+epenet@users.noreply.github.com> * Cleanup trailing space --------- Co-authored-by: Franck Nijhof <frenck@frenck.nl> Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Update exception handling for python3.13 for getpass.getuser(). As part of the CHANGELOG:
This updates the logic added in #59667 to handle both the python3.13 exceptions in addition to previously thrown exceptions from earlier versions. In python 3.13 and beyond, the only exception thrown is
OSError
.This is currently observed as an issue on some unsupported container use cases, but also appears like it can happen in other scenarios also.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: