Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocking call in netdata #132209

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Fix blocking call in netdata #132209

merged 2 commits into from
Dec 4, 2024

Conversation

cnico
Copy link
Contributor

@cnico cnico commented Dec 3, 2024

Breaking change

None

Proposed change

Correction of #125260 which is a warning for the netdata integration at startup of home assistant for a blocking call.

It requires an upgrade to netdata dependency. The code change is here : home-assistant-ecosystem/python-netdata@1.1.0...1.3.0
The solution is simply to inject the httpx client from homeassistant to the netdata library.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 3, 2024

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (netdata) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of netdata can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign netdata Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@epenet epenet changed the title Correction of https://github.com/home-assistant/core/issues/125260 Fix blocking call in netdata Dec 3, 2024
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cnico 👍

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cnico 👍

../Frenck

@frenck frenck merged commit 5600ad0 into home-assistant:dev Dec 4, 2024
64 of 65 checks passed
frenck pushed a commit that referenced this pull request Dec 4, 2024
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
zweckj pushed a commit to zweckj/home-assistant-core that referenced this pull request Dec 5, 2024
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netdata: warnings in 2024.9 - "Detected blocking call"
4 participants