-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix blocking call in netdata #132209
Fix blocking call in netdata #132209
Conversation
Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cnico 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cnico 👍
../Frenck
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
Breaking change
None
Proposed change
Correction of #125260 which is a warning for the netdata integration at startup of home assistant for a blocking call.
It requires an upgrade to netdata dependency. The code change is here : home-assistant-ecosystem/python-netdata@1.1.0...1.3.0
The solution is simply to inject the httpx client from homeassistant to the netdata library.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: