Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump thinqconnect to 1.0.2 #132131

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

LG-ThinQ-Integration
Copy link
Contributor

Breaking change

Proposed change

Bump thinqconnnect to 1.0.2
Link to the diff : thinq-connect/pythinqconnect@b34e068

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek
Copy link
Member

joostlek commented Dec 3, 2024

Is this the correct diff? It goes from 1.0.0 to 1.0.2

@LG-ThinQ-Integration
Copy link
Contributor Author

@joostlek
It's just an error in the github commit. Pypi's 1.0.1 library was correct.

@joostlek
Copy link
Member

joostlek commented Dec 4, 2024

Can we maybe start using tags correctly in the library? And preferably also add a CI for publishing to pypi for increased transparency?

@joostlek joostlek added this to the 2024.12.0 milestone Dec 4, 2024
@joostlek joostlek merged commit 7a98497 into home-assistant:dev Dec 4, 2024
59 of 61 checks passed
frenck pushed a commit that referenced this pull request Dec 4, 2024
Co-authored-by: yunseon.park <yunseon.park@lge.com>
zweckj pushed a commit to zweckj/home-assistant-core that referenced this pull request Dec 5, 2024
Co-authored-by: yunseon.park <yunseon.park@lge.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants