Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyTibber to 0.30.4 #129844

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Bump pyTibber to 0.30.4 #129844

merged 6 commits into from
Nov 6, 2024

Conversation

Danielhiversen
Copy link
Member

Breaking change

Proposed change

Fix tibber.get_prices
Update Tibber lib Danielhiversen/pyTibber@0.30.3...0.30.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
@Danielhiversen Danielhiversen marked this pull request as ready for review November 5, 2024 04:55
@joostlek joostlek changed the title Fix tibber.get_prices Bump pyTibber to 0.30.4 Nov 5, 2024
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, can you take a look?

@home-assistant
Copy link

home-assistant bot commented Nov 5, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 5, 2024 09:59
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
@Danielhiversen Danielhiversen marked this pull request as ready for review November 5, 2024 20:39
@home-assistant home-assistant bot requested a review from joostlek November 5, 2024 20:39
@joostlek joostlek added this to the 2024.11.0 milestone Nov 6, 2024
@joostlek joostlek merged commit 370d7d6 into dev Nov 6, 2024
42 checks passed
@joostlek joostlek deleted the 125674 branch November 6, 2024 10:44
frenck pushed a commit that referenced this pull request Nov 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tibber.get_prices results in "Unknown Error", reloading integration solves the issue
3 participants