-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new on values for Tuya Presence Detection Sensor #129801
Conversation
Hey there @tuya, @zlinoliver, @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @KunalAggarwal 👍
../Frenck
@KunalAggarwal I'm confused why you create an merge commit there? Was there an issue? What has changed? |
I happened to tap the Update Branch button on the action tab. Nothing has changed. Sorry about that. |
I believe "peaceful" should also be considered an "on" value shouldn't it? If I understood the values correctly it appears that peaceful is for when you are present but standing still and that sort of thing. |
Breaking change
Proposed change
The new presence sensors by Tuya, have multiple values to indicate presence, including
large_move
,small_move
andpresence
. So, updating the on value for the "hps" human presence sensor. See attached module API response with valid values.See this sensor: https://solution.tuya.com/projects/CMavulo8wvpzqz
Documentation on the Chinese version shows these values in the API: https://developer.tuya.com/cn/docs/iot/s?id=K9j2w4p710ge9
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: