Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-linkplay to 0.0.17 #129683

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Nov 2, 2024

Proposed change

3 fixes:

  • Includes a bugfix for the multiroom introduced during this beta where the wrong IP address was accessed.
  • It also includes a fix to take into account if a linkplay device contains more than 10 presets. This was enforced to 10 at library and in the integration. The integration will need an additional PR.
  • Pushes "wifi" to the input sources, just like the companion app for LinkPlay and the web application. When playing over network (streaming), it will show up as "wifi" as input source. The input map was adjusted in the integration already to prevent an error.

Also includes the neccessary changes to support time syncing, but this feature needs integration changes.
Python requirements have been set a little bit lower to cause less conflicts with other integrations.

https://github.com/Velleman/python-linkplay/releases/tag/v0.0.16
https://github.com/Velleman/python-linkplay/releases/tag/v0.0.17
Velleman/python-linkplay@v0.0.15...v0.0.17
Please backport this change to the current beta.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 2, 2024

Hey there @Velleman, mind taking a look at this pull request as it has been labeled with an integration (linkplay) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of linkplay can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign linkplay Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek joostlek added this to the 2024.11.0 milestone Nov 2, 2024
@balloob
Copy link
Member

balloob commented Nov 4, 2024

@silamon looks like you committed an updated src/linkplay/__version__.py in v17 which wasn't intended.

@balloob balloob merged commit 38afcbb into home-assistant:dev Nov 4, 2024
46 checks passed
bramkragten pushed a commit that referenced this pull request Nov 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants