Update template switch to new format #128944
Conversation
|
Hey there @PhracturedBlue, @tetienne, @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Petro31
force-pushed
the
add-new-template-switch-config
branch
from
efc4262 to
7404c25
Compare
| @@ -219,3 +297,90 @@ async def async_turn_off(self, **kwargs: Any) -> None: | |||
| if self._template is None: | |||
| self._state = False | |||
| self.async_write_ha_state() | |||
|
|
|||
|
|
|||
| class TriggerSwitchEntity(TriggerEntity, SwitchEntity, RestoreEntity): | |||
There was a problem hiding this comment.
Wouldn't it be better to have an AbstractSwitchTemplate class from which both SwitchTemplate and TriggerSwitchEntity` inherit?
There was a problem hiding this comment.
It would be a nice idea, however none of the existing template entities do this and there are challenges that arise. It is something that I want to do, but I want it to be done at a integration level, not domain level.
| async def async_turn_on(self, **kwargs: Any) -> None: | ||
| """Fire the on action.""" | ||
| if self._on_script: | ||
| await self.async_run_script(self._on_script, context=self._context) |
There was a problem hiding this comment.
I don't see the need for a new method which takes the script as a parameter. Either async_run_script should be defined in this class and grab the required script from the object properties OR just add this as one of the variables when calling self._on_script.async_run(...).
There was a problem hiding this comment.
That new method will be used by all trigger based template entities (light, fan, select, etc) to provide the action scripts with the this variable, just like non trigger based template entities. This function is needed to fix this long standing issue. It's added here first and it will be added to all other domains at a later date.
|
Hi there @Petro31 👋 There is a merge conflict, could you take a look? Thanks! 👍 ../Frenck |
Petro31
force-pushed
the
add-new-template-switch-config
branch
from
a97d21c to
3e6c9d1
Compare
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Petro31
force-pushed
the
add-new-template-switch-config
branch
from
c301956 to
b54c34c
Compare
Breaking change
No
Proposed change
Add switch to new template yaml format
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: