Remove deprecated retries and lazy_error_count yaml option
#128932
+0
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
breaking-change
cla-signed
Hacktoberfest
has-tests
integration: modbus
small-pr
jpbede
commented
Oct 21, 2024
Comment on lines
-575
to
-586
| { | ||
| CONF_TYPE: TCP, | ||
| CONF_HOST: TEST_MODBUS_HOST, | ||
| CONF_PORT: TEST_PORT_TCP, | ||
| CONF_RETRIES: 3, | ||
| CONF_SENSORS: [ | ||
| { | ||
| CONF_NAME: "dummy", | ||
| CONF_ADDRESS: 9999, | ||
| } | ||
| ], | ||
| }, |
There was a problem hiding this comment.
Removed, as there is already a case with these parameters without the retries.
jpbede
commented
Oct 21, 2024
Comment on lines
-169
to
-179
| { | ||
| CONF_SENSORS: [ | ||
| { | ||
| CONF_NAME: TEST_ENTITY_NAME, | ||
| CONF_ADDRESS: 51, | ||
| CONF_DATA_TYPE: DataType.INT32, | ||
| CONF_VIRTUAL_COUNT: 5, | ||
| CONF_LAZY_ERROR: 3, | ||
| } | ||
| ] | ||
| }, |
crug80
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Since 2024.1 the YAML configuration options
retriesandlazy_error_countare deprecated. These options have now been completely removed. Please adjust your YAML configuration if necessary.Proposed change
See breaking change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: