-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fan mode when heat/cool is idle in homekit #128618
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @Jc2k, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
e611f46
to
6f76dac
Compare
Nice! Can you add the possible values for this characteristic to aiohomekit here https://github.com/Jc2k/aiohomekit/blob/main/aiohomekit/model/characteristics/const.py as an enum instead of having a const in the integration? |
aiohomekit 3.2.5 has the enums needed now. |
6f76dac
to
7c9180c
Compare
Proposed change
For some Homekit thermostat device such as an Ecobee, there is a FAN_STATE_CURRENT field that can track the state of fan independently from whether the system is heating/cooling/idle. Since the HASS thermostat display already has a mode for displaying when the Fan is on this is just displaying when the fan is active using that existing HVACAction.FAN support when the cooler is idle.
This functionality also mirrors the way the Ecobee cloud integration behaves, showing a "Fan" state when the heat/cool is idle, but the fan is on (such as due to a fan hold, or minimum hourly runtime).
(Edit by @Jc2k to add Jc2k/aiohomekit@3.2.3...3.2.5)
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: