Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fan mode when heat/cool is idle in homekit #128618

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Xeio
Copy link

@Xeio Xeio commented Oct 18, 2024

Proposed change

For some Homekit thermostat device such as an Ecobee, there is a FAN_STATE_CURRENT field that can track the state of fan independently from whether the system is heating/cooling/idle. Since the HASS thermostat display already has a mode for displaying when the Fan is on this is just displaying when the fan is active using that existing HVACAction.FAN support when the cooler is idle.

This functionality also mirrors the way the Ecobee cloud integration behaves, showing a "Fan" state when the heat/cool is idle, but the fan is on (such as due to a fan hold, or minimum hourly runtime).

(Edit by @Jc2k to add Jc2k/aiohomekit@3.2.3...3.2.5)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Xeio Xeio requested review from Jc2k and bdraco as code owners October 18, 2024 02:00
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Xeio

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @Jc2k, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (homekit_controller) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homekit_controller can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homekit_controller Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@Jc2k
Copy link
Member

Jc2k commented Oct 18, 2024

Nice!

Can you add the possible values for this characteristic to aiohomekit here https://github.com/Jc2k/aiohomekit/blob/main/aiohomekit/model/characteristics/const.py as an enum instead of having a const in the integration?

@Jc2k
Copy link
Member

Jc2k commented Oct 21, 2024

aiohomekit 3.2.5 has the enums needed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants