Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reconfigure flow to ring integration #128357

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

sdb9696
Copy link
Contributor

@sdb9696 sdb9696 commented Oct 14, 2024

Proposed change

This will allow users to generate new hardware_ids at ring.com if their current id is blacklisted from sending event notifications.

Also updates the reauth flow to use the new helpers and not cache entires.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@sdb9696 sdb9696 mentioned this pull request Oct 18, 2024
19 tasks
Copy link
Contributor

@CFenner CFenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

homeassistant/components/ring/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/ring/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/ring/config_flow.py Outdated Show resolved Hide resolved
joostlek and others added 2 commits October 21, 2024 15:19
Co-authored-by: Christopher Fenner <9592452+CFenner@users.noreply.github.com>
@joostlek joostlek merged commit f8f87ec into home-assistant:dev Oct 21, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants