Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preset handling issue in ViCare #128167

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Conversation

CFenner
Copy link
Contributor

@CFenner CFenner commented Oct 11, 2024

Proposed change

Prevent integration from failing when preset is not part of the enum.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@CFenner CFenner marked this pull request as ready for review October 11, 2024 14:12
@joostlek joostlek added this to the 2024.10.2 milestone Oct 11, 2024
@joostlek joostlek merged commit 791c3cd into home-assistant:dev Oct 11, 2024
31 checks passed
@CFenner CFenner deleted the presetError branch October 11, 2024 15:29
frenck pushed a commit that referenced this pull request Oct 11, 2024
* add test case

* fix test case

* fix issue

* change order
@frenck frenck mentioned this pull request Oct 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing preset in ViCare integration fails when device provides presets that are not supported by HA
3 participants