-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aurora alert sensor always Off #127780
Conversation
Hey there @djtimca, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Fix aurora integration issue #121954. Update threshold when user changes configuration. Threshold change was previously not acted upon until a restart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This integration has quite a good test coverage and active tests for most of the things. Can we add some tests for this case too?
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Fix aurora integration issue #121954. Update threshold when user changes configuration and update the sensor state accordingly. Threshold change was previously not acted upon until a restart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @johangus65 👍
../Frenck
Fix aurora integration issue #121954.
Update threshold when user changes configuration.
Threshold change was previously not acted upon
until a restart.
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: