Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aurora alert sensor always Off #127780

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fix aurora alert sensor always Off #127780

merged 2 commits into from
Oct 8, 2024

Conversation

johangus65
Copy link
Contributor

Fix aurora integration issue #121954.
Update threshold when user changes configuration.

Threshold change was previously not acted upon
until a restart.

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Oct 7, 2024

Hey there @djtimca, mind taking a look at this pull request as it has been labeled with an integration (aurora) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of aurora can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign aurora Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Fix aurora integration issue #121954.
Update threshold when user changes configuration.

Threshold change was previously not acted upon
until a restart.
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This integration has quite a good test coverage and active tests for most of the things. Can we add some tests for this case too?

../Frenck

homeassistant/components/aurora/__init__.py Show resolved Hide resolved
@home-assistant
Copy link

home-assistant bot commented Oct 7, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 7, 2024 09:33
Fix aurora integration issue #121954.
Update threshold when user changes configuration
and update the sensor state accordingly.

Threshold change was previously not acted upon
until a restart.
@johangus65 johangus65 marked this pull request as ready for review October 8, 2024 09:13
@home-assistant home-assistant bot requested a review from frenck October 8, 2024 09:13
@frenck frenck added this to the 2024.10.2 milestone Oct 8, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @johangus65 👍

../Frenck

@frenck frenck merged commit 2171652 into home-assistant:dev Oct 8, 2024
30 of 31 checks passed
@johangus65 johangus65 deleted the issue_121954 branch October 8, 2024 21:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aurora alert sensor always Off
2 participants