-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Reolink Home Hub main level switches #126697
Merged
edenhaus
merged 8 commits into
home-assistant:dev
from
starkillerOG:reolink_depricate_rec
Sep 25, 2024
Merged
Remove Reolink Home Hub main level switches #126697
edenhaus
merged 8 commits into
home-assistant:dev
from
starkillerOG:reolink_depricate_rec
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: reolink
small-pr
PRs with less than 30 lines.
by-code-owner
Quality Scale: No score
labels
Sep 24, 2024
starkillerOG
changed the title
Depricate Reolink Home Hub main level record switch
Depricate Reolink Home Hub main level switches
Sep 24, 2024
edenhaus
changed the title
Depricate Reolink Home Hub main level switches
Deprecate Reolink Home Hub main level switches
Sep 25, 2024
edenhaus
added
deprecation
Indicates a breaking change to happen in the future
breaking-change
and removed
bugfix
deprecation
Indicates a breaking change to happen in the future
labels
Sep 25, 2024
edenhaus
changed the title
Deprecate Reolink Home Hub main level switches
Remove Reolink Home Hub main level switches
Sep 25, 2024
Starkiller looks if it's possible to deprecate with a repair issue instead of directly removing it |
doing the Reolink-aio version bump now |
edenhaus
added
deprecation
Indicates a breaking change to happen in the future
and removed
breaking-change
labels
Sep 25, 2024
edenhaus
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @starkillerOG 👍
zxdavb
pushed a commit
to zxdavb/hass
that referenced
this pull request
Sep 25, 2024
Co-authored-by: Robert Resch <robert@resch.dev>
frenck
pushed a commit
that referenced
this pull request
Sep 26, 2024
Co-authored-by: Robert Resch <robert@resch.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cherry-picked
cla-signed
deprecation
Indicates a breaking change to happen in the future
has-tests
integration: reolink
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
The redundant "Record", "Email on event", "FTP upload", "Push notifications", and "Buzzer on event" switches on the Reolink Home Hub have been depricated since the new firmware no longer supports these.
Please use the equally named switches under each of the camera devices (connected to the Home Hub) instead to turn on/off recording.
This only applies to the Reolink Home Hub, not to Reolink NVRs.
Proposed change
The new Reolink Home Hub firmware will remove the ability to enable/disable recording, email, FTP, Push, and Buzzer on the Hub level (main switch).
Therefore clean-up this entity.
Enabeling/disabeling these switches on the camera level on the Home Hub will remain as is.
This has been done by Reolink because it was confusing to users that in order for recordings to be made on a camera both the main switch (Hub level) and the camera recording switch needed to be turned ON.
The main switch is redundant since when a user wants to disable all recordings, the user can just turn OFF all the recording switches (camera level) on each of the cameras (connected to the Home Hub).
Seperate version bump or Reolink-aio: #126778
Bump reolink-aio to 0.9.11:
Additions:
Bug fixes:
Full Changelog: starkillerOG/reolink_aio@0.9.10...0.9.11
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: