Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hwam] Add HWAM Smart Control integration #126578

Draft
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

lordyavin
Copy link

@lordyavin lordyavin commented Sep 23, 2024

Proposed change

An integration to monitor and control HWAM® SmartControl™ wood burning stoves. It uses the pystove library.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lordyavin

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Initial commit of the HWAM Smart Control integr. Add HWAM Smart Control integration Sep 25, 2024
@autinerd
Copy link
Contributor

Hi, please add the following to the PR description:

  • A short description on what the integration is about
  • A link to the repository of the library

Thanks!

@lordyavin
Copy link
Author

I will do. I saw the long PR template 😜 I did not expect to get feedback before the PR is ready for review. Did I create it to early?

@autinerd
Copy link
Contributor

Ah, sorry, I didn't see that you created it as draft, as the bot automatically puts it in draft when requesting the CLA 😄 I can wait if you want 😅

@lordyavin lordyavin reopened this Oct 5, 2024
lordyavin added a commit to lordyavin/homeassistant-brands that referenced this pull request Oct 20, 2024
@lordyavin lordyavin closed this Oct 20, 2024
@lordyavin
Copy link
Author

need to start from next again.

@lordyavin lordyavin deleted the hwamsmartctrl branch October 20, 2024 23:11
@lordyavin lordyavin restored the hwamsmartctrl branch October 20, 2024 23:21
@lordyavin lordyavin reopened this Oct 20, 2024
@lordyavin lordyavin changed the title Add HWAM Smart Control integration [hwam] Add HWAM Smart Control integration Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants