Fix cast doing I/O in event loop #12632
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Follow-up on #12474.
We're doing I/O inside
async_setup_platform
, because thepychromecast.Chromecast
constructor calls some http endpoint on the chromecast. We shouldn't do that. I've now looked through the code again, and have not found another instance of this.Thanks to @rytilahti for pointing this out!
Though this should fix the issue, we could also additionally wrap the whole call in a timeout, to make it even more secure:(Doesn't work sincepychromecast.Chromecast
isn't a coroutine)Example entry for
configuration.yaml
(if applicable):Checklist:
If the code does not interact with devices:
tox
run successfully. Your PR cannot be merged unless tests pass