-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix qbittorrent error when torrent count is 0 #126146
Fix qbittorrent error when torrent count is 0 #126146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DAcodedBEAT
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @geoffreylagaisse, @finder39, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Clean and simple. Nicely done and thank you! |
439bff7
to
3d30301
Compare
… function Added a check to handle cases where the 'torrents' data is None, avoiding a `TypeError` when attempting to get the length of a `NoneType` object. The function now returns 0 if 'torrents' is None, ensuring robust behavior when no torrent data is available.
3d30301
to
1d9930e
Compare
@finder39 thanks for the quick review! how long do these PRs typically take to get approved and merged by core maintainers? I would love to see less stacktraces in my logs 😅 |
NoneType
for torrents in count_torrents_in_states
function
Workaround is to start downloading more torrents right :P |
It's not too long as you can see, especially on smaller PRs like this :) |
Proposed change
Added a check to handle cases where the 'torrents' data is None, avoiding a
TypeError
when attempting to get the length of aNoneType
object. The function now returns 0 if 'torrents' is None, ensuring robust behavior when no torrent data is available.Here was the traceback when looking at the home assistant logs:
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: