Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The logbook will load a lot of events that it ends up discarding. This change moves some of that filtering to SQL and thus avoids a lot of useless Python objects to be created.
The performance impact depends on the database content but my production setup has about a 50% improvement in logbook loading time (on top of #12566). Nevertheless, the logbook is still very slow :-/
The potential speedup depends on #12580.
Related issue (if applicable): fixes #12572
Checklist:
If the code does not interact with devices:
tox
run successfully.Tests have been added to verify that the new code works.