Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update string formatting to use f-string on components #125987

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

albertomontesg
Copy link
Contributor

@albertomontesg albertomontesg commented Sep 15, 2024

Proposed change

This change updates the string formatting to use f-strings on components code.

This is to have the code reflect the existing code style guidelines for Home Assistant (documentation).

(2/3) This change focusses on components code as suggested in #125945

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @albertomontesg 👋

There is a merge conflict. Could you take a look and resolve it?

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft September 16, 2024 18:19
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@albertomontesg albertomontesg marked this pull request as ready for review September 16, 2024 18:42
@home-assistant home-assistant bot requested a review from frenck September 16, 2024 18:42
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Sep 19, 2024
homeassistant/components/sense/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/sense/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/signal_messenger/notify.py Outdated Show resolved Hide resolved
homeassistant/components/stream/worker.py Show resolved Hide resolved
homeassistant/components/venstar/__init__.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 19, 2024 08:54
@albertomontesg albertomontesg marked this pull request as ready for review September 19, 2024 09:02
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare
Copy link
Member

Codecov seems stuck. Merging.

@MartinHjelmare MartinHjelmare merged commit b2401bf into home-assistant:dev Sep 19, 2024
42 of 44 checks passed
@albertomontesg albertomontesg deleted the f-string-components branch September 19, 2024 09:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality core smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants