Fix fix isy994 fan detection #12595
Merged
Fix fix isy994 fan detection #12595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. FanLincs have two nodes: one light and one fan motor. In order for each node to get detected as different Hass entity types, I removed the device-type check for FanLinc. The logic will now fall back on the uom checks which should work just fine. (An alternative approach here would be to special case FanLincs and handle them directly - but seeing as the newer 5.x ISY firmware already handles this much better using NodeDefs, I think this quick and dirty approach is fine for the older firmware.) Fixes home-assistant#12030 2. Some non-dimming switches were appearing as `light`s in Hass due to an duplicate NodeDef being in the light domain filter. Removed! Fixes home-assistant#12340 3. The `unqiue_id` property was throwing an error for certain entity types that don't have an `_id` property from the ISY. This issue has always been present, but was exposed by the entity registry which seems to be the first thing to actually try reading the `unique_id` property from the isy994 component.
ISY reports "med" in the uom, not "medium"
homeassistant
added
integration: isy994
small-pr
balloob
approved these changes
Feb 22, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
My #12421 PR failed to fix the first cited issue, which is that FanLincs were not getting properly detected as one light and one fan. Turns out, we really do need to special-case FanLincs because their Insteon type is in the
lightfamily, even though they are a combo device. How annoying!This PR adds a small special case for the FanLinc so that its light subnode gets added as a Hass
light. This time, the change has actually been tested by someone with a FanLinc and is confirmed working!Related issue (if applicable): fixes #12030
Pull request in home-assistant.github.io with documentation (if applicable): None
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass