-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monarch Money cashflow sensor bugfix #125774
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
small-pr
PRs with less than 30 lines.
integration: monarch_money
by-code-owner
Quality Scale: No score
labels
Sep 11, 2024
MartinHjelmare
changed the title
Monarch Money - Bugfix in Cashflow sensor
Fix Monarch Money cashflow sensor
Sep 12, 2024
jeeftor
changed the title
Fix Monarch Money cashflow sensor
BugFix Monarch Money cashflow sensor
Sep 13, 2024
jeeftor
changed the title
BugFix Monarch Money cashflow sensor
[BETA BUG FIX] - BugFix Monarch Money cashflow sensor
Sep 25, 2024
frenck
changed the title
[BETA BUG FIX] - BugFix Monarch Money cashflow sensor
Monarch Money cashflow sensor bugfix
Sep 26, 2024
frenck
requested changes
Sep 26, 2024
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
frenck
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jeeftor 👍
../Frenck
frenck
added a commit
that referenced
this pull request
Sep 27, 2024
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
zxdavb
pushed a commit
to zxdavb/hass
that referenced
this pull request
Sep 27, 2024
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
by-code-owner
cherry-picked
cla-signed
integration: monarch_money
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
THIS NEEDS TO BE FIXED IN CURRENT BETA
I forgot to pass in the Year range for the Year to Date Calculations. They were doing a Month Calculation.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: