Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monarch Money cashflow sensor bugfix #125774

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Conversation

jeeftor
Copy link
Contributor

@jeeftor jeeftor commented Sep 11, 2024

Breaking change

Proposed change

THIS NEEDS TO BE FIXED IN CURRENT BETA

I forgot to pass in the Year range for the Year to Date Calculations. They were doing a Month Calculation.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@jeeftor jeeftor marked this pull request as ready for review September 11, 2024 17:42
@MartinHjelmare MartinHjelmare changed the title Monarch Money - Bugfix in Cashflow sensor Fix Monarch Money cashflow sensor Sep 12, 2024
@jeeftor jeeftor changed the title Fix Monarch Money cashflow sensor BugFix Monarch Money cashflow sensor Sep 13, 2024
@jeeftor jeeftor changed the title BugFix Monarch Money cashflow sensor [BETA BUG FIX] - BugFix Monarch Money cashflow sensor Sep 25, 2024
@frenck frenck changed the title [BETA BUG FIX] - BugFix Monarch Money cashflow sensor Monarch Money cashflow sensor bugfix Sep 26, 2024
@frenck frenck added this to the 2024.10.0 milestone Sep 26, 2024
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 26, 2024 18:30
@jeeftor jeeftor marked this pull request as ready for review September 26, 2024 18:47
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jeeftor 👍

../Frenck

@frenck frenck merged commit 76858f0 into home-assistant:dev Sep 27, 2024
25 of 26 checks passed
frenck added a commit that referenced this pull request Sep 27, 2024
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@jeeftor jeeftor deleted the monarch_patch branch September 27, 2024 11:49
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Sep 27, 2024
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants