Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for milight single 1CH dimmer (limitlessLED) #12558

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Added support for milight single 1CH dimmer (limitlessLED) #12558

merged 1 commit into from
Feb 20, 2018

Conversation

rubenverhoef
Copy link
Contributor

@rubenverhoef rubenverhoef commented Feb 20, 2018

Description:

Add support for a 1CH (MiLight) LED dimmer see happyleavesaoc/python-limitlessled#27 and happyleavesaoc/python-limitlessled#33

Related issue (if applicable): fixes #8521, fixes #11073, fixes #11121
I think this should fix this issue mentioned in the forum: https://community.home-assistant.io/t/milight-wifi-controller-ibox-2-with-led-stripe/28945

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4718

Example entry for configuration.yaml (if applicable):

    bridges:
      - host: 192.168.0.42
        groups:
        - number: 1
          name: Kitchen
          type: dimmer

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Contributor

Hi @rubenverhoef,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@amelchio
Copy link
Contributor

Welcome :-). As this limitlessled update also has fixes for a number of issues reported for HA, I have added the issue numbers to your description.

Copy link
Contributor

@amelchio amelchio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@amelchio amelchio merged commit 5d29d88 into home-assistant:dev Feb 20, 2018
@balloob balloob mentioned this pull request Feb 22, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants