Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numeric_state condition spamming on unavailable state #12550

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

OttoWinter
Copy link
Member

Description:

When a sensor reports an unknown or unavailable state, numeric_state conditions based off of this sensor will spam the logs:

screen shot 2018-02-20 at 13 21 09

Note this doesn't change actually any behavior, it simply doesn't spam the log on these two specific values.

Example entry for configuration.yaml (if applicable):

condition: numeric_state
entity_id: sensor.temperature
below: 42

Checklist:

  • The code change is tested and works locally.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@OttoWinter OttoWinter requested a review from a team as a code owner February 20, 2018 12:23
@homeassistant homeassistant added cla-signed core small-pr PRs with less than 30 lines. labels Feb 20, 2018
@pvizeli pvizeli merged commit 3077444 into home-assistant:dev Feb 20, 2018
@balloob balloob mentioned this pull request Feb 22, 2018
@OttoWinter OttoWinter deleted the fix-condition-spam branch March 13, 2018 19:17
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants