Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiolifx and aiolifx-themes to support more than 82 zones #125487

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

Djelibeybi
Copy link
Contributor

Proposed change

Bump aiolifx and aiolifx-themes to enable support for multizone lights with more than 82 zones (the previous limit). This required rewriting some of the tests to align with the underlying library changes.

While this does resolve the linked issue, it does so pretty inefficiently. I'm working on updating the LIFX integration itself to remove a bunch of historical stuff that is no longer required. However, updating the tests for that is going to be time-consuming, so I don't have an ETA for it yet.

aiolifx release: https://github.com/aiolifx/aiolifx/releases/tag/1.1.1
aiolifx changelog: aiolifx/aiolifx@1.0.9...1.1.1

aiolifx-themes release: https://github.com/Djelibeybi/aiolifx-themes/releases/tag/v0.5.5
aiolifx-themes changelog: Djelibeybi/aiolifx-themes@v0.5.0...v0.5.5

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek joostlek merged commit 5108e1a into home-assistant:dev Sep 8, 2024
43 checks passed
@joostlek joostlek added this to the 2024.9.2 milestone Sep 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lifx Integration - Set State only works for first 82 zones
3 participants