Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sphinx build #12535

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Fix Sphinx build #12535

merged 1 commit into from
Feb 20, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 20, 2018

Description:

Sphinx build was broken because imports didn't resolve. Couldn't figure out how to fix the import, so just copy pasted the values.

CC @lucasweb78

@balloob balloob requested a review from a team as a code owner February 20, 2018 04:50
@homeassistant homeassistant added small-pr PRs with less than 30 lines. cla-signed labels Feb 20, 2018
@balloob balloob mentioned this pull request Feb 20, 2018
1 task
@balloob balloob merged commit 336b007 into dev Feb 20, 2018
@balloob balloob deleted the fix-sphinx branch February 20, 2018 04:51
@lucasweb78
Copy link
Contributor

I wonder if this is related to this discussion sphinx-doc/sphinx#1226. It looks like Sphinx has some issues when you try and import setup.py as it conflicts with a file it's expecting. Although it appears like the issue was meant to be resolved several version ago.

Either way I can confirm this fix solved the problem locally. Thanks

@balloob balloob mentioned this pull request Feb 22, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants