Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for room sensors in ViCare integration #125243

Draft
wants to merge 16 commits into
base: dev
Choose a base branch
from
Draft

Add support for room sensors in ViCare integration #125243

wants to merge 16 commits into from
+467 −3

Conversation

CFenner
Copy link
Contributor

@CFenner CFenner commented Sep 4, 2024 •
edited
Loading

Proposed change

Add support for ViCare room sensors.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@CFenner CFenner mentioned this pull request Sep 5, 2024
Merged
19 tasks
@blob810
Copy link
Contributor

blob810 commented Sep 5, 2024

I‘ll test it tonight. After upgrade to HA2024.09.0 my fan entity is grayed out.

@CFenner
Copy link
Contributor Author

CFenner commented Sep 5, 2024 •
edited
Loading

@blob810 lets talk on Discord (pyvicare, home assistant) about the fan, my username there is Hafenstrand.

CFenner
CFenner commented Sep 15, 2024
View reviewed changes
homeassistant/components/vicare/sensor.py
@@ -745,6 +745,22 @@ class ViCareSensorEntityDescription(SensorEntityDescription, ViCareRequiredKeysM
options=["ready", "production"],
value_getter=lambda api: _filter_pv_states(api.getPhotovoltaicStatus()),
),
ViCareSensorEntityDescription(
key="room_temperature",
translation_key="room_temperature",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the default translations should be sufficient as this is the only entity of the device beside humidity.

image

homeassistant/components/vicare/strings.json Outdated Show resolved Hide resolved
homeassistant/components/vicare/strings.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: vicare new-feature Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CFenner @blob810