Add WatchYourLAN integration #125238
Open
Add WatchYourLAN integration #125238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
This was referenced Sep 4, 2024
|
Approved +2 |
joostlek
requested changes
Sep 4, 2024
MartinHjelmare
changed the title
|
@joostlek I appreciate the thorough review and think I've been able to address all the comments. Looking forward to another round of review, when you have time! |
…hyourlanclient library
joostlek
requested changes
Sep 5, 2024
…t library version
joostlek
requested changes
Sep 22, 2024
…nnecessary code This commit refactors the WatchYourLAN sensor entity descriptions by removing the mac_address field and simplifying the code. The native_value method in the WatchYourLANGenericSensor class has also been updated to return None when the device_field is not found. This improves the overall readability and maintainability of the code.
…fy_ssl field Update the WatchYourLAN sensor entity descriptions in the strings.json file. Also, add the verify_ssl field to the user data step in the config flow.
autinerd
suggested changes
Sep 24, 2024
joostlek
requested changes
Sep 24, 2024
|
Apologies for the slow response time here. Life events got in the way of me responding to your last feedback in a timely manner. |
Don't apologize for that, life events go before an integration :) |
joostlek
requested changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adding support for WatchYourLAN (https://github.com/aceberg/WatchYourLAN) integration. This will allow HA to fetch information from the WatchYourLAN API and process the results at entities.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
Feature: Add WatchYourLAN integration docs home-assistant.io#34584
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: