Frontier silicon async #12503
Merged
Frontier silicon async #12503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me-assistant into frontier_silicon_async
pvizeli
requested changes
Feb 20, 2018
| self._mute = fs_device.mute | ||
| self._media_image_url = fs_device.play_info_graphics | ||
| end = time.time() | ||
| _LOGGER.debug('Frontier Silicon device update took: %s', (end-start)) |
There was a problem hiding this comment.
Remove this debug time handling stuff
houndci-bot
reviewed
Feb 20, 2018
| @@ -6,6 +6,9 @@ | |||
| """ | |||
| import logging | |||
|
|
|||
| import asyncio | |||
| import time | |||
|
Removed debug. Build fails for Python 3.6 - I does not look like it is because of the frontier_silicon component. |
pvizeli
approved these changes
Feb 20, 2018
Merged
ghost
added
integration: frontier_silicon
and removed
platform: media_player.frontier_silicon
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #
fixes #11853
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass